perf: cache table page metadata during memo eviction - #1234
Open
MichaReiser wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Merging this PR will not alter performance
Comparing Footnotes
|
MichaReiser
force-pushed
the
optimize-memo-eviction-cursor
branch
2 times, most recently
from
July 5, 2026 13:26
c3efbda to
5950f5a
Compare
MichaReiser
commented
Jul 5, 2026
| use crate::zalsa::Zalsa; | ||
|
|
||
| #[test] | ||
| fn memo_cursor_caches_pages_with_ingredient_specific_memo_indices() { |
Contributor
Author
There was a problem hiding this comment.
I'm leaning towards deleting this test
MichaReiser
marked this pull request as ready for review
July 5, 2026 13:37
MichaReiser
force-pushed
the
optimize-memo-eviction-cursor
branch
2 times, most recently
from
July 9, 2026 11:57
f33e7a5 to
353707a
Compare
MichaReiser
force-pushed
the
optimize-memo-eviction-cursor
branch
from
July 9, 2026 19:39
353707a to
db905fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the last resolved table page while evicting memo values, avoiding repeated page, vtable, memo-index, and type lookups for page-local victim streams. It slightly reduces the number of instructions on the eviction path for LRU, but it's a bigger impact for SIEVE where the eviction policy intentionally evicts items in their page order.
This keeps eviction policies storage-agnostic while preserving arbitrary ID ordering; the isolated sweep prototype improved by roughly 15%.
Benchmarks
Local benchmarks, because CodSpeed is bugged right now