Support block defaults for cattr and mattr#316
Open
dicnunz wants to merge 1 commit intorubyworks:mainfrom
Open
Support block defaults for cattr and mattr#316dicnunz wants to merge 1 commit intorubyworks:mainfrom
dicnunz wants to merge 1 commit intorubyworks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cattr/cattr_reader/cattr_writer/cattr_accessormattrhelpersIssueHunt bounty:
mattr/cattr(aka attribute accessors) to keep up with the times #258Testing
bundle install --path vendor/bundle --without guardbundle exec ruby-test -Ilib/core test/core/module/test_mattr.rbbundle exec ruby-test -Ilib/core test/core/moduleruby -c lib/core/facets/module/mattr.rbcattr_accessorandmattr_accessorblock defaultsgit diff --checkNote: a plain
bundle install --path vendor/bundletries to install the optionalguardgroup and fails on this machine becauseffi-1.17.4-x86_64-darwinrequires Ruby >= 3.0, while the system Ruby here is 2.6.10. Installing without theguardgroup was enough for the test suite commands above.