Organizations can reserve gems - #6777
Draft
brian-penguin wants to merge 7 commits into
Draft
Conversation
Why this change is being made: - As we work towards a public rollout we want to reduce the surface area for problems in the Organization handle namespaces. What were the changes made to support this: - allow for a handle starting with a number (in this case 37signals) - dont allow for organization handles which are taken by User handles (I'm not 100% on this one as of currently since I know the use of service user accounts is something that happens) - Add a BUNCH of reserved words to the organization handle reserved list. This includes all our routes path segments, a list of prominent ruby/rails companies (minus the ones who have already added organizations), a bunch of words that look like they could belong to the app or rubygems namespaces, words that are tricky and annoying to sort out like "nil", and words that imply "trust" like "admin" or "safety" - Update the seeds to use gem-org as the local test org - Update the lib/patterns to include ORGANIZATION_HANDLE_PATTERN which is the same as the base handle pattern but allows for integers leading
Why this change is being made: - I think this wants to exist in the database instead. Since there's still a feature toggle gate on this we have plenty of ability to change this before GA What were the changes made to support this: - remove the section
Why this change is being made: - We are going to re-use this functionality to allow orgs to make reservations on gem names for themselves. Right now there's not going to be limits to this functionality other than making this a "request" model that we can allow admin to accept or reject What were the changes made to support this: - Add an optional reference to the gem_name_reservations table
Why this change is being made: - also add to the avo resources What were the changes made to support this: - Make it so we can reference an organization from an GemNameReservation
Why this change is being made: - We want to see these from Avo
Why this change is being made: - We want to let organizations reserve their own gem names for their private gems What were the changes made to support this: - Add a new route/controller/view etc - Update the translations files - tests for the things Next: - the pusher tests are failing, they are related to setup but we are also changing the assumptions on how this works. So you can't make a reservation at all if a gem exists with the same name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we are still in Beta with our organizations approach we don't have gates on how many gem reservations can be made (yet) because we don't have a concept of "tiers" for organizations (yet).