Remove default_url_options[]= in ApplicationMailer - #6772
Open
hmcguire-shopify wants to merge 1 commit into
Open
Remove default_url_options[]= in ApplicationMailer#6772hmcguire-shopify wants to merge 1 commit into
hmcguire-shopify wants to merge 1 commit into
Conversation
The mutation predates the other method of configuring these values: it first [appeared][1] on `ProfileMailer` in 2009, while `config.action_mailer.default_url_options` was only added to the [test][2] environment in 2010, to [production][3] in 2014, and to [development][4] in 2015. The per-mailer mutations were then copy-pasted into each new mailer until they were [consolidated][5] into `ApplicationMailer` in 2024. Since every environment sets `config.action_mailer.default_url_options`, the `ApplicationMailer` mutation just rewrites the same values into the same hash and can be removed. [1]: e69fa4c [2]: 8235147 [3]: 4dc8e0a [4]: 06f4a5f [5]: 372b7f9
brian-penguin
self-requested a review
August 18, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutation predates the other method of configuring these values: it first appeared on
ProfileMailerin 2009, whileconfig.action_mailer.default_url_optionswas only added to the test environment in 2010, to production in 2014, and to development in 2015. The per-mailer mutations were then copy-pasted into each new mailer until they were consolidated intoApplicationMailerin 2024.Since every environment sets
config.action_mailer.default_url_options, theApplicationMailermutation just rewrites the same values into the same hash and can be removed.