Fix gem transfer when co-owners are already organization members - #6768
Open
anton-bondaronok wants to merge 1 commit into
Open
Fix gem transfer when co-owners are already organization members#6768anton-bondaronok wants to merge 1 commit into
anton-bondaronok wants to merge 1 commit into
Conversation
Skip existing memberships instead of inserting duplicates.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6768 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 531 531
Lines 11443 11450 +7
=======================================
+ Hits 11188 11195 +7
Misses 255 255 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6740
Transfer used to always insert new memberships from approved invites. That failed when a co-owner was already in the target org: the duplicate
Membershipwas invalid and unsaved, thenOrganizationMailer.user_invitedraisedActiveJob::SerializationError.Existing members are now skipped. They stay off the users step, their org role is unchanged, and they are not emailed. Their individual gem ownership is still removed so they access the gem through the organization. Role changes continue to go through organization management. New invitees are created and emailed as before.
How to test
rubygem1/gem-maintainertoRubyGems). Confirm succeeds; membership role is unchanged; gem ownership is removed; no invite email; the user does not appear on the users step.bin/rails test test/models/rubygem_transfer_test.rb test/functional/rubygems/transfer/users_controller_test.rb