Treat Organization Handles as their own type of handles - #6738
Open
brian-penguin wants to merge 2 commits into
Open
Treat Organization Handles as their own type of handles#6738brian-penguin wants to merge 2 commits into
brian-penguin wants to merge 2 commits into
Conversation
brian-penguin
force-pushed
the
reserve-organization-handles
branch
from
August 3, 2026 21:45
ddee6e2 to
7ff226d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6738 +/- ##
==========================================
+ Coverage 97.76% 97.81% +0.04%
==========================================
Files 530 533 +3
Lines 11422 11770 +348
==========================================
+ Hits 11167 11513 +346
- Misses 255 257 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brian-penguin
commented
Aug 6, 2026
Why this change is being made: - As we work towards a public rollout we want to reduce the surface area for problems in the Organization handle namespaces. What were the changes made to support this: - allow for a handle starting with a number (in this case 37signals) - dont allow for organization handles which are taken by User handles (I'm not 100% on this one as of currently since I know the use of service user accounts is something that happens) - Add a BUNCH of reserved words to the organization handle reserved list. This includes all our routes path segments, a list of prominent ruby/rails companies (minus the ones who have already added organizations), a bunch of words that look like they could belong to the app or rubygems namespaces, words that are tricky and annoying to sort out like "nil", and words that imply "trust" like "admin" or "safety" - Update the seeds to use gem-org as the local test org - Update the lib/patterns to include ORGANIZATION_HANDLE_PATTERN which is the same as the base handle pattern but allows for integers leading
Why this change is being made: - I think this wants to exist in the database instead. Since there's still a feature toggle gate on this we have plenty of ability to change this before GA What were the changes made to support this: - remove the section
brian-penguin
force-pushed
the
reserve-organization-handles
branch
from
August 12, 2026 14:11
c7237ce to
d7ae499
Compare
brian-penguin
marked this pull request as ready for review
August 12, 2026 14:12
brian-penguin
force-pushed
the
reserve-organization-handles
branch
from
August 17, 2026 21:31
d07bfdf to
d7ae499
Compare
colby-swandale
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is being made:
What were the changes made to support this: