Fix webauthn CLI verification always rendering success after credential verification - #6365
Open
Hemang360 wants to merge 2 commits into
Open
Fix webauthn CLI verification always rendering success after credential verification#6365Hemang360 wants to merge 2 commits into
Hemang360 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
==========================================
- Coverage 97.07% 94.47% -2.61%
==========================================
Files 489 489
Lines 10373 10426 +53
==========================================
- Hits 10070 9850 -220
- Misses 303 576 +273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When authenticating via Webauthn during
gem push, the browser would show "Failed to fetch" even though authentication succeeded and the gem was pushed. This happened because the server redirected the browser tolocalhost:PORTto deliver the otp, and if that redirect failed, the browser showed an error, despite the gem CLI already having the otp via polling.Fix by removing the localhost redirect entirely. The server now always returns "success" after Webauthn verification (the same path safari already used), and the gem CLI relies on polling to receive the otp, which is already how the safari flow worked.
Fixes #4317