Add specs for #each passing source yields by block arity (Enumerator and Lazy)#1365
Open
sampokuokkanen wants to merge 1 commit into
Open
Add specs for #each passing source yields by block arity (Enumerator and Lazy)#1365sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
sampokuokkanen
force-pushed
the
enumerable-value-pack
branch
from
527751a to
9773b36
Compare
1 task
eregon
reviewed
Jun 2, 2026
| require_relative '../../../spec_helper' | ||
| require_relative '../shared/each' | ||
|
|
||
| describe "Enumerator::Lazy#each" do |
Member
There was a problem hiding this comment.
There is no Enumerator::Lazy#each on CRuby:
irb(main):003> Enumerator::Lazy.instance_method :each
=> #<UnboundMethod: Enumerator#each(*)>So let's have both it_behaves_like in core/enumerator/each_spec.rb.
That way we test the same (lazy and non-lazy cases) but we ruby/spec doesn't pretend there is a method which doesn't exist on CRuby.
eregon
reviewed
Jun 2, 2026
Member
eregon
left a comment
eregon
left a comment
There was a problem hiding this comment.
Looks good besides the file organization tweak
…and Lazy) Unlike the Enumerable collection methods, which pack yielded source values via rb_enum_values_pack() (0 args -> nil, 1 arg -> the value, N args -> Array), #each passes them to the block by ordinary block arity (rb_yield_values2() in CRuby): a single-argument block receives the first value, a multi-argument block destructures, and a splat block gathers them.
sampokuokkanen
force-pushed
the
enumerable-value-pack
branch
from
9773b36 to
4e845c5
Compare
Contributor
Author
|
Thank you! I fixed the organization of the files and now lazy is also tested in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the Enumerable collection methods, which pack yielded source values via rb_enum_values_pack() (0 args -> nil, 1 arg -> the value, N args -> Array), #each passes them to the block by ordinary block arity (rb_yield_values2() in CRuby): a single-argument block receives the first value, a multi-argument block destructures, and a splat block gathers them.
Pin this explicitly via a shared describe used by both Enumerator#each and Enumerator::Lazy#each, complementing the value_packing specs.
This is so we catch bugs like I had in my implementation of packing in truffleruby/truffleruby#4272.