Skip to content

Update Array#2987

Open
sampersand wants to merge 20 commits into
ruby:masterfrom
sampersand:swesterman/2026-05-22/update-Array
Open

Update Array#2987
sampersand wants to merge 20 commits into
ruby:masterfrom
sampersand:swesterman/2026-05-22/update-Array

Conversation

@sampersand

@sampersand sampersand commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

This PR completely updates Array's signatures, and rewrites the test harness to work with it.

Note that there's some # where E: ... comments strewn about in the code. This marks places where, when we eventually get around to implementing the where clause, we should implement them in the Array.

@sampersand sampersand changed the title swesterman/2026 05 22/update Array Update Array Jun 3, 2026
@sampersand sampersand force-pushed the swesterman/2026-05-22/update-Array branch 2 times, most recently from 786a245 to 31a4a54 Compare June 3, 2026 21:28
Comment thread core/array.rbs
Comment thread core/array.rbs Outdated
#
alias any? all?
def any?: () -> bool
| (_Pattern[E] pattern) -> bool

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Use RBS::Ops:_Matches

Comment thread core/array.rbs Outdated
Comment thread core/array.rbs Outdated
Comment thread core/array.rbs
Comment thread core/array.rbs
Comment thread core/array.rbs
@sampersand sampersand force-pushed the swesterman/2026-05-22/update-Array branch 2 times, most recently from 1eef064 to 0fa718e Compare June 3, 2026 21:38
@sampersand sampersand marked this pull request as ready for review June 3, 2026 21:49
@soutaro soutaro added this to the RBS 4.1 milestone Jun 4, 2026
Comment thread core/array.rbs
Comment thread core/array.rbs Outdated
@sampersand sampersand force-pushed the swesterman/2026-05-22/update-Array branch from cc52661 to 4691c6d Compare June 4, 2026 06:20
@sampersand sampersand force-pushed the swesterman/2026-05-22/update-Array branch from 2f1d30d to 21d3886 Compare June 5, 2026 03:25

@sampersand sampersand left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did final check, should good

@sampersand sampersand force-pushed the swesterman/2026-05-22/update-Array branch from dfe3641 to a814469 Compare June 9, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants