Skip to content

fix Grape helpers modified given helper module#1338

Open
sevaorlov wants to merge 1 commit into
ruby-grape:masterfrom
sevaorlov:fix/grape-helper-module
Open

fix Grape helpers modified given helper module#1338
sevaorlov wants to merge 1 commit into
ruby-grape:masterfrom
sevaorlov:fix/grape-helper-module

Conversation

@sevaorlov
Copy link
Copy Markdown

fixes #1335

@sevaorlov sevaorlov force-pushed the fix/grape-helper-module branch 4 times, most recently from 8737400 to 98e6516 Compare March 26, 2016 11:55
@dblock
Copy link
Copy Markdown
Member

dblock commented Apr 1, 2016

I am torn whether we want this. If you think "this is a Ruby module", then in Ruby if you write module MyHelperModule you'd expect it to reopen a previous one. On the other hand, we could consider modules namespaces, and maybe what you suggest has less of a surprise. Please add your 👍 or 👎 to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grape::DSL::Helpers::ClassMethods#helpers modifies helper module

2 participants