Conversation
skip_space_or_newline wrote "\n" via `write`, which does not increment @line. A trailing-newline comment inside parens left @line one short of reality, so later `dedent_calls` looked up @line_to_call_info on the wrong line and trimmed leading characters off an unrelated call, deleting the method receiver. Use write_line so newline bookkeeping stays consistent; the manual @column reset becomes unnecessary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357 — rufo deleted method receivers in some block bodies, producing invalid Ruby.
skip_space_or_newlinewrote a trailing-newline comment viawrite "\n", which doesn't advance@line; stale@linethen causeddedent_callsto trim leading chars off an unrelated later line, dropping the receiver.write_lineso@line/@column/@last_was_newlinestay consistent; manual@column = next_indentis no longer needed.junk_drawer.rb.specmirroring the reproducer in rufo broke my code (method receiver was deleted) #357.🤖 Generated with Claude Code