Add typed support for (a few more) gap and multicolumn CSS properties#599
Open
mfonism wants to merge 4 commits into
Open
Add typed support for (a few more) gap and multicolumn CSS properties#599mfonism wants to merge 4 commits into
mfonism wants to merge 4 commits into
Conversation
* column-count * column-width * column-rule-color * column-rule-style * column-rule-width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is NOT a PR for the
phantom-typesprojectThis PR adds typed support for a few CSS properties that come up naturally when building layouts, especially when spacing items in flex/grid containers or working with multicolumn content.
It adds support for the following CSS properties:
gaprow-gapcolumn-gapcolumn-countcolumn-widthcolumn-rule-colorcolumn-rule-widthcolumn-rule-styleThe following related shorthands were intentionally not covered:
columnscolumn-ruleA clean typed API for both shorthand forms would require introducing new dedicated value types, as opposed to reusing existing ones loosely.
Potential future additions:
word-spacingword-break