Add @container queries#580
Open
celsobonutti wants to merge 12 commits into
Open
Conversation
celsobonutti
changed the title
…nQuery variants Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…laration Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tics Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… nesting The spec documents v1 nesting semantics: when withContainer is nested inside withMedia (or vice versa), the outer rule applies and the inner condition is dropped. The WithMedia branch of applyStyles previously left a nested ContainerRule untouched (via styleBlockToMediaRule), letting the inner container survive and silently discarding the outer media condition. The MediaRule branch of toContainerRule had the opposite bug: it kept the inner media rule unchanged instead of folding it into the outer container rule. Both now special-case the inner at-rule and substitute the outer condition, consistent with the existing (and now corrected) comments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Fix Css.Global nested @container to and-combine conditions (inner name wins) instead of dropping the inner condition, matching the Style-path toContainerRule and the sibling media helper's append semantics. - Add tests for global nested-container combine and Style-path inner-name- wins nesting (1694 -> 1696 tests). - Add CHANGELOG entry for the container-queries feature set. - Fill in empty docs for Css.Media gt/lt/ge/le/eq, Css.Container width/height/aspectRatio/landscape/portrait, and note custom-ident validation caveats on containerName/containerNames/container. - Run elm-format over touched files; align containerRanges token qualification to bare (no collision) for consistency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add container query support (Css.Container)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@containerqueries.expr, anyOf, allOf, inverse, condition, gt, lt, ge, le, eq, betweenfunctions to Css.Media so they have the same helper functions for their algebras.