ci: add CodeQL workflow to satisfy code_scanning branch rule#35
Merged
Conversation
rsk-develop-protection requires CodeQL results on every merge to rsk/develop, but the repo has no CodeQL workflow, so no analysis has ever run and every PR is stuck on "Waiting for Code Scanning results." Scoped to Go (the repo's single root module) for now; Rust/JS coverage can follow separately.
There was a problem hiding this comment.
Pull request overview
Adds a minimal GitHub Actions CodeQL workflow for the RSK fork to unblock the code_scanning branch protection rule on merges to rsk/develop, initially scoped to Go (root go.mod).
Changes:
- Introduces a new
rsk-codeqlworkflow that runs CodeQL on PRs targetingrsk/**and on pushes torsk/develop. - Pins third-party actions by commit SHA and grants the minimal permissions needed to upload CodeQL results.
Comments suppressed due to low confidence (2)
.github/workflows/rsk-codeql.yml:33
- Same as above: this SHA pin is good, but the inline "v4.37.3" annotation is likely to become misleading over time (and may already be incorrect). Prefer omitting the version comment when pinning by SHA unless you can guarantee it matches the referenced commit/tag.
- uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3
.github/workflows/rsk-codeql.yml:38
- Same as above for the analyze step: consider removing the inline "v4.37.3" annotation when pinning by SHA to avoid an incorrect version reference in the workflow.
- uses: github/codeql-action/analyze@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4.37.3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsk-develop-protection requires CodeQL results on every merge to rsk/develop, but the repo has no CodeQL workflow, so no analysis has ever run and every PR is stuck on "Waiting for Code Scanning results." Scoped to Go (the repo's single root module) for now; Rust/JS coverage can follow separately.