Skip to content

[build] Validate changesets in CI #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Juice10 wants to merge 6 commits into
base: main
Choose a base branch
from
+225 −865
Open

[build] Validate changesets in CI #1811

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
24db71a
Add changeset package validation
Juice10 Mar 19, 2026
4680f7d
Use changeset status for validation
Juice10 Mar 19, 2026
b83c110
Upgrade changesets cli
Juice10 Mar 19, 2026
3cf5265
Fetch master before changeset validation
Juice10 Mar 19, 2026
97140b3
Fetch full history for changeset status
Juice10 Mar 19, 2026
3ceed1c
Create local master ref for changesets
Juice10 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/large-mails-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Run Changesets' built-in status command in CI and upgrade `@changesets/cli` so invalid changeset metadata fails with a clear workspace error instead of an opaque runtime crash.
Comment on lines +1 to +4
2 changes: 2 additions & 0 deletions .github/workflows/eslint-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:
run: yarn install --frozen-lockfile
env:
PUPPETEER_SKIP_DOWNLOAD: true
- name: Validate changesets
Comment on lines +36 to +40
run: yarn lint:changesets
- name: Build Packages
run: NODE_OPTIONS='--max-old-space-size=4096' yarn build:all
- name: Eslint Check
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
env:
PUPPETEER_SKIP_DOWNLOAD: true

- name: Validate changesets
run: yarn lint:changesets

- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
],
"devDependencies": {
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"@changesets/cli": "^2.30.0",
"@monorepo-utils/workspaces-to-typescript-project-references": "^2.8.2",
"@types/prettier": "2.7.3",
"@typescript-eslint/eslint-plugin": "^5.62.0",
Expand All @@ -45,6 +45,7 @@
"scripts": {
"build:all": "NODE_OPTIONS='--max-old-space-size=4096' yarn turbo run prepublish",
"references:update": "yarn workspaces-to-typescript-project-references",
"lint:changesets": "changeset status",
"test": "yarn turbo run test --concurrency=1 --continue",
"test:watch": "yarn turbo run test:watch",
"test:update": "yarn turbo run test:update",
Expand All @@ -54,7 +55,7 @@
"dev": "yarn turbo run dev --concurrency=18",
"repl": "cd packages/rrweb && npm run repl",
"live-stream": "cd packages/rrweb && yarn live-stream",
"lint": "yarn run concurrently --success=all -r -m=1 'yarn run markdownlint docs' 'ESLINT_USE_FLAT_CONFIG=false yarn eslint packages/*/src --ext .ts,.tsx,.js,.jsx,.svelte'",
"lint": "yarn run concurrently --success=all -r -m=1 'yarn run markdownlint docs' 'ESLINT_USE_FLAT_CONFIG=false yarn eslint packages/*/src --ext .ts,.tsx,.js,.jsx,.svelte' 'yarn lint:changesets'",
"lint:report": "ESLINT_USE_FLAT_CONFIG=false yarn eslint --output-file eslint_report.json --format json packages/*/src --ext .ts,.tsx,.js,.jsx",
"release": "yarn build:all && changeset publish"
},
Expand Down
Loading
Loading