Rename Django auth permission for Django RQ from "view" to "admin" - #811
Open
terencehonles wants to merge 1 commit into
Open
Rename Django auth permission for Django RQ from "view" to "admin"#811terencehonles wants to merge 1 commit into
terencehonles wants to merge 1 commit into
Conversation
This change renames the "view" permission to "admin" as the provided Django RQ admin views allow data modification and an admin may incorrectly grant unintended permissions if the codename is used in a query.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRenames the Dashboard model's declared permission from "view" to "admin" in the model Meta options, and adds a Django migration that updates model options and swaps existing Permission codenames between "view" and "admin" for the Dashboard content type. ChangesDashboard Permission Rename
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
terencehonles
marked this pull request as ready for review
July 9, 2026 10:16
Contributor
Author
|
I tested the migration works appropriately in our app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames the "view" permission to "admin" as the provided Django RQ admin views allow data modification and an admin may incorrectly grant unintended permissions if the codename is used in a query.
Summary by CodeRabbit