Skip to content

address RHEL uncrustify warnings.#942

Open
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/rhel-uncrustify-warnings
Open

address RHEL uncrustify warnings.#942
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/rhel-uncrustify-warnings

Conversation

@fujitatomoya
Copy link
Copy Markdown
Contributor

Description

see https://ci.ros2.org/job/ci_linux-rhel/8929/testReport/

-- run_test.py: invoking following command in '/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/geometry2/tf2_ros':
 - /home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_uncrustify/bin/ament_uncrustify --xunit-file /home/jenkins-agent/workspace/ci_linux-rhel/ws/build/tf2_ros/test_results/tf2_ros/uncrustify.xunit.xml --language C++
Code style divergence in file 'include/tf2_ros/static_transform_broadcaster.hpp':

--- include/tf2_ros/static_transform_broadcaster.hpp
+++ include/tf2_ros/static_transform_broadcaster.hpp.uncrustify
@@ -103 +103 @@
-    : StaticTransformBroadcaster(
+  : StaticTransformBroadcaster(
@@ -124 +124 @@
-    : StaticTransformBroadcaster(
+  : StaticTransformBroadcaster(

Code style divergence in file 'include/tf2_ros/transform_broadcaster.hpp':

--- include/tf2_ros/transform_broadcaster.hpp
+++ include/tf2_ros/transform_broadcaster.hpp.uncrustify
@@ -106 +106 @@
-    : TransformBroadcaster(
+  : TransformBroadcaster(
@@ -128 +128 @@
-    : TransformBroadcaster(RequiredInterfaces(node_parameters, node_topics), qos, options)
+  : TransformBroadcaster(RequiredInterfaces(node_parameters, node_topics), qos, options)

2 files with code style divergence

Fixes # (issue)

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya fujitatomoya requested a review from ahcorde May 15, 2026 05:07
@fujitatomoya
Copy link
Copy Markdown
Contributor Author

Pulls: #942
Gist: https://gist.githubusercontent.com/fujitatomoya/0349c6f38baf40ef5285f7fe270c5ff2/raw/5f6f930d9f40078cd638b201d5febc67fa9d5ffc/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_ros
TEST args: --packages-above tf2_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19277

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Contributor Author

ah, we cannot have this in both ways...

@fujitatomoya
Copy link
Copy Markdown
Contributor Author

these APIs have been deprecated, can we just remove these instead? @ahcorde what do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant