Update cartographer to deal with newer ceres#24
Merged
Conversation
Signed-off-by: zjwoody <zhengj@google.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Otherwise modern gcc complains that these are possibly used uninitialized. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
at-wat
pushed a commit
to alpine-ros-pkgs/cartographer
that referenced
this pull request
Jul 24, 2025
* Use Manifold instead of LocalParameterization. * Changes to deal with old and new ceres. * Make sure to fully initialize test articles. Otherwise modern gcc complains that these are possibly used uninitialized. Signed-off-by: zjwoody <zhengj@google.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com>
at-wat
pushed a commit
to alpine-ros-pkgs/cartographer
that referenced
this pull request
Jul 24, 2025
* Use Manifold instead of LocalParameterization. * Changes to deal with old and new ceres. * Make sure to fully initialize test articles. Otherwise modern gcc complains that these are possibly used uninitialized. Signed-off-by: zjwoody <zhengj@google.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, newer versions of Ceres have removed
ceres::LocalParameterization, and you are now expected to useceres::Manifoldinstead.I took cartographer-project#1882 as a starting point. I then modified things so that this would work with both older ceres (that has
ceres::LocalParameterization) and newer ceres (that only hasceres::Manifold). I was perhaps overly cautious here, in that I made sure to make no changes for older ceres with the #ifdef sections; the new code is only ever activated for newer ceres. The reasoning for that was to make sure that this still works for e.g. Humble and Iron, and that there are definitely no regressions there.I also added a few more changes to fix up some spurious warnings in CMake and in Eigen. The result should be a successful build on both Ubuntu 22.04 and Ubuntu 24.04.