[pepper_robot] disable odom with param

[Naoki-Kameyama]

Because I'd like to use Visual SLAM with Pepper.

Pleas merge this PR after ros-naoqi/naoqi_bridge#58

[mikaelarguedas]

closing/opening to trigger new travis job

[k-okada]

I think we have to release naoqi_bridge
I also think we should set true as default value until someone provide (v)slam code/launch in this repository.

[mikaelarguedas]

yes we'll need to wait for naoqi_bridge to be released indeed.
Agreed for the default value, I think it should be set to false as in the parent PR.
@Naoki-Kameyama could you update your PR with the default value set to true ?

[mikaelarguedas]

thanks @Naoki-Kameyama
Waiting until next naoqi_bridge to squash and merge this

[furushchev]

@Naoki-Kameyama Is this should be true instead of True?

[mikaelarguedas]

Thanks for pointing it out, it seems that the same comment made by @k-okada a few days ago doesn't show up on this PR so thanks for reposting it.

[Naoki-Kameyama]

Thank you for pointed.

[Naoki-Kameyama]

This PR is required to release naoqi_bridge ros-naoqi/naoqi_bridge#59.

[yoneken]

His claim is seems to be satisfied now! ros/rosdistro#12759

[Karsten1987]

what about extending this config file and then set the parameter manually once vslam is available?

[Karsten1987]

any updates on this?

[suryaambrose]

@Karsten1987 I did not get your point (extending the config file, which is in a different project).

Otherwise, lgtm

[mikaelarguedas]

@nlyubova same thing as #37 (comment), this new argument should be added to naoqi_driver.launch

[nlyubova]

I would agree with @Karsten1987 about the confi file and this is already a parameter in this config file in Naoqi Driver. And here you propose to pass it as a parameter in a launch file to the same Naoqi Driver, so it means that in Naoqi Driver there are will be at least two entries for this parameter (in a launch file and in a config file), so I am not sure if it is a good option or not. @suryaambrose do you think it is ok?