Remove AIX support - #23131
Conversation
This was used to work-around AIX deficiency
Test Results 23 files 23 suites 3d 14h 9m 13s ⏱️ For more details on these failures, see this check. Results for commit 03e2663. |
guitargeek
left a comment
There was a problem hiding this comment.
Thanks a lot for the initiative! I think this only needs some fixes in roottest/scripts/Event.mk, then it's ready to merge.
| $(CMDECHO) /usr/ibmcxx/bin/makeC++SharedLib $(OutPutOpt) $@ $(LIBS) -p 0 $^ | ||
| else | ||
| ifeq ($(ARCH),aix5) | ||
| $(CMDECHO) /usr/vacpp/bin/makeC++SharedLib $(OutPutOpt) $@ $(LIBS) -p 0 $^ |
There was a problem hiding this comment.
The nested ifeq-else-endif triplets are broken now. You also have to remove the trailing else after the line you just removed, and the two endifs corresponding to the ifeqs you removed
dpiparo
left a comment
There was a problem hiding this comment.
lgtm when @guitargeek's comments are addressed.
For when is the the cleanup foreseen for preprocessor guards for discontinued OSes, e.g. macOS versions :-P?
AIX has not been tested in a very long while (like only v5 and older) and is not yet supported enough by LLVM, see https://llvm.org/docs/JITLink.html#roadmap:
In addition, all the work-around are likely obsolete and/or have better alternative in AIX 7.3+ and thus should be redone if (when?) there is demand for a port to AIX.