Skip to content

[Doxy] Fetch MathJax from the web rather than vendoring it - #23095

Merged
dpiparo merged 3 commits into
root-project:masterfrom
dpiparo:external_mathjax
Aug 18, 2026
Merged

[Doxy] Fetch MathJax from the web rather than vendoring it#23095
dpiparo merged 3 commits into
root-project:masterfrom
dpiparo:external_mathjax

Conversation

@dpiparo

@dpiparo dpiparo commented Aug 18, 2026

Copy link
Copy Markdown
Member

And add minor fixes on the way

@dpiparo dpiparo self-assigned this Aug 18, 2026
@dpiparo
dpiparo requested a review from couet as a code owner August 18, 2026 13:33
Comment on lines 1084 to +1086
../../core/clib/ \
../../core/lzma/ \
../../core/lz4/ \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exclude core/lzma and core/lz4 and core/newdelete?

I understand why to exclude core/clib (which btw would be no longer explicitly needed with #23040)

Same for core/textinput, in my opinion it should not be excluded, only the part core/textinput/src/textinput (which would no longer need explicit removal with #23046)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this observation. Some more doc will definitively not break the bank. I think lzma was removed not to expose in the doc of the public interface details related to compression. LZ4 was added at a later stage, and this file was never updated... Or at least that is my theory...

@dpiparo
dpiparo merged commit 7edc3a6 into root-project:master Aug 18, 2026
2 of 3 checks passed
@dpiparo
dpiparo deleted the external_mathjax branch August 18, 2026 16:51
@linev

linev commented Aug 19, 2026

Copy link
Copy Markdown
Member

@dpiparo

This was too fast - mathjax also used with JSROOT.
See builtins/mathjax/CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants