Skip to content

[Feat][SDK-594] Compress payload and update payload max size to 1mb #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buongarzoni merged 9 commits into from
May 4, 2026

refactor(reactive-streams): use compression-intent pattern for safe t…

1f5f214
Select commit
Loading
Failed to load commit list.
Merged

[Feat][SDK-594] Compress payload and update payload max size to 1mb #371

refactor(reactive-streams): use compression-intent pattern for safe t…
1f5f214
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 4, 2026 in 18m 43s

Code review found 2 potential issues

Found 6 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit rollbar-reactive-streams-reactor/src/main/java/com/rollbar/reactivestreams/notifier/sender/http/ReactorAsyncHttpClient.java:154-164 Resource cleanup gaps in new gzip compression code

Annotations

Check warning on line 164 in rollbar-reactive-streams-reactor/src/main/java/com/rollbar/reactivestreams/notifier/sender/http/ReactorAsyncHttpClient.java

See this annotation in the file changed.

@claude claude / Claude Code Review

Resource cleanup gaps in new gzip compression code 

Two related resource-cleanup gaps were introduced by this PR's new gzip code. (1) The new `compress()` helpers in `ReactorAsyncHttpClient.java:154-164` and `ApacheRequestPublisher.java:129-139` construct a `GZIPOutputStream` and call `gzip.write(...)`/`gzip.close()` linearly without try/finally — if `write` throws, `close()` (and therefore `Deflater.end()` which releases native off-heap memory) never runs. (2) In `ReactorAsyncHttpClient.send()` line 53, a pooled Netty `ByteBuf` is allocated befo
View more details on Claude