Adapt to rocq-prover/rocq#21987 (secvar status)#719
Merged
Conversation
SkySkimmer
force-pushed
the
context-secvar
branch
2 times, most recently
from
c11af59 to
a9125c9
Compare
SkySkimmer
commented
May 20, 2026
Comment on lines
+455
to
+459
| List.fold_right (fun d env -> | ||
| (* WTF HACK FIXME *) | ||
| if Environ.mem_named (Context.Named.Declaration.get_id d) env then env | ||
| else Environ.push_named ProofVar d env) | ||
| nctx env |
Contributor
Author
There was a problem hiding this comment.
not sure wtf is going on here but it seems equations is pushing an already taken name
this is already the case in master but breaks more stuff in rocq-prover/rocq#21987 so I put in a hack to avoid the double pushing
SkySkimmer
force-pushed
the
context-secvar
branch
from
a9125c9 to
75d5ce5
Compare
SkySkimmer
force-pushed
the
context-secvar
branch
from
75d5ce5 to
2a735b5
Compare
Member
|
please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.