Skip to content

Bump Waterproof - #1055

Open
pimotte wants to merge 1 commit into
rocq-community:mainfrom
pimotte:chore/waterproof-bump
Open

Bump Waterproof#1055
pimotte wants to merge 1 commit into
rocq-community:mainfrom
pimotte:chore/waterproof-bump

Conversation

@pimotte

@pimotte pimotte commented Nov 3, 2025

Copy link
Copy Markdown

The aim of this PR is to obtain an updated wasm build for inclusion in waterproof-vscode.

(If I'm missing something and this still needs to be on a branch, please let me know:))

@pimotte
pimotte force-pushed the chore/waterproof-bump branch from bc57192 to 1cf66ba Compare November 3, 2025 15:20
@ejgallego

Copy link
Copy Markdown
Collaborator

Thanks @pimotte !

Note that we have a different setup for main vs stable Rocq branches. For Rocq's master we do pin waterproof as a submodule, for stable branches, we install an opam package. See the WP_VERSION in Makefile.

As of today, we update this variable in every branch, but we could add a little table to main if desired.

Should we also update the stable versions opam file?

@ejgallego ejgallego added this to the 0.2.5 milestone Nov 3, 2025
@ejgallego ejgallego self-assigned this Nov 3, 2025
@pimotte

pimotte commented Nov 3, 2025

Copy link
Copy Markdown
Author

Yeah, that would be a good idea, but the release is not on opam yet, so I can follow up with that later:)

@ejgallego

Copy link
Copy Markdown
Collaborator

opam also supports pinning to a particular branch or commit, so if you wanna me to push a particular update please let me know, or you can just PR targeting the right Rocq branch.

@ejgallego ejgallego removed this from the 0.2.5 milestone Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants