Skip to content

Avoid stripping single and double quotes from data:image urls #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megatronCGN wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid stripping single and double quotes from data:image urls #10

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0a13f
Avoid stripping single and double quotes from data:image urls
megatronCGN Jan 11, 2018
50a5832
Use strict equality check
mpdude Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ var func = require('rework-plugin-function');
module.exports = function(fn) {
return func({
url: function(path){
if (path.indexOf('data:image') == 0) {
Copy link
Copy Markdown

@techwes techwes Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value here will always be a number so === should be used (as it is generally preferred over == equal)

Copy link
Copy Markdown

@mpdude mpdude Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techwes resolved that

return 'url("' + path + '")';
}
path = path.split('"').join('');
path = path.split('\'').join('');
return 'url("' + fn.call(this, path.trim()) + '")';
Expand Down