feat(lint): discover helm charts from EC Config manifests#718
Merged
feat(lint): discover helm charts from EC Config manifests#718
Conversation
Add support for discovering HelmChart declarations from embeddedcluster.replicated.com/v1beta1 Config manifest extensions.helmCharts. This allows validation to properly match EC Config helm charts against local chart archives, preventing false-positive warnings for charts declared in EC Config manifests.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Move struct declarations inside the yaml.v3 decode loop in both parseHelmChartManifest and parseECConfigHelmCharts. yaml.v3's decoder modifies the target in place and does not clear fields absent in the current document, causing phantom entries or false duplicates in multi-document YAML files. Also removes unreachable return after the infinite for loop in parseHelmChartManifest.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f7950a. Configure here.
- parseECConfigHelmCharts: use ecConfigAPIVersion constant from embedded_cluster.go instead of hardcoded string to prevent silent discovery failures if the API version changes. - TestLintValidation_ECConfigMissingArchive: use t.Fatalf instead of t.Errorf for the warnings length check to prevent index-out-of-bounds panic when result.Warnings is empty.
Member
Author
|
[sc-137591] |
sgalsaleh
reviewed
May 8, 2026
| seenFiles[path] = true | ||
|
|
||
| // Quick kind check before parsing | ||
| isConfig, err := hasKind(path, "Config") |
Member
There was a problem hiding this comment.
there's multiple Config kinds with different api versions (e.g. KOTS's config, ec's Config, etc...). i guess the below parse continues on error so that might be fine with the current implementation you have but might cause issues later on.
Member
Author
There was a problem hiding this comment.
added hasAPIVersionKind function
sgalsaleh
previously approved these changes
May 8, 2026
…scovery Replace the overly-broad hasKind(path, "Config") quick check in DiscoverECConfigHelmCharts with hasAPIVersionKind(path, apiVersion, kind), which verifies both apiVersion and kind. This avoids false-positive matches against KOTS Config (kots.io/v1beta1) or any other Config kind when scanning manifest files for EC Config helmCharts declarations.
Add comprehensive tests covering: - EC Config match (correct apiVersion + kind) - KOTS Config mismatch (same kind, different apiVersion) - Multi-document YAML with EC Config present - Multi-document YAML without EC Config - Empty file returns false - Valid EC Config parsed by yaml decoder (not regex fallback)
sgalsaleh
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for discovering HelmChart declarations from
embeddedcluster.replicated.com/v1beta1Config manifestextensions.helmCharts.This allows validation to properly match EC Config helm charts against local chart archives, preventing false-positive warnings for charts declared in EC Config manifests.
Changes
DiscoverECConfigHelmCharts()scans manifest globs for EC Config documents and extractsspec.extensions.helmCharts[].chartentriesDiscoverHelmChartManifests()now merges both kotsHelmChartmanifests and EC Config helm chart declarations