Skip to content

fix selected editing handles being covered by later-rendered polygons - #10475

Open
0x-mayank wants to merge 2 commits into
remotion-dev:mainfrom
0x-mayank:fix-selected-handles-z-index
Open

fix selected editing handles being covered by later-rendered polygons#10475
0x-mayank wants to merge 2 commits into
remotion-dev:mainfrom
0x-mayank:fix-selected-handles-z-index

Conversation

@0x-mayank

Copy link
Copy Markdown

Summary

Fix selected editing handles being covered by later-rendered polygons.

Issue

Fixes #10459

Changes

  • Render selected outline polygons separately from editing controls.
  • Render editing controls after all polygons so they remain visible and hit-testable.

@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview Aug 15, 2026 2:26pm
remotion Ready Ready Preview Aug 15, 2026 2:26pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The Studio overlay reordering is correct, but the PR also deletes a @ts-expect-error in packages/media-parser/src/writers/node.ts that is still load-bearing — it will break the media-parser typecheck, and it is unrelated to this fix. Please restore that line (details inline).

Reviewed changes

  • SelectedOutlineRenderer — Split each outline's rendering into two passes: all polygons first, then all editing controls last, so a later-rendered polygon can no longer cover a previously rendered element's handles. Preserves the existing per-outline control ordering and the frozen drag ordering, and leaves the UV / transform-origin layers in place.
  • SelectedOutlineElement — Added optional renderControls / renderPolygon props with defaults true, gating each pass. No behavior change for non-renderer callers (there are none besides the renderer).
  • media-parser/node.ts — Unrelated removal of // @ts-expect-error ahead of new Blob([file]).

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

Comment thread packages/media-parser/src/writers/node.ts
Comment thread packages/studio/src/components/SelectedOutlineRenderer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio: Keep selected editing handles above canvas polygons

1 participant