fix selected editing handles being covered by later-rendered polygons - #10475
Open
0x-mayank wants to merge 2 commits into
Open
fix selected editing handles being covered by later-rendered polygons#104750x-mayank wants to merge 2 commits into
0x-mayank wants to merge 2 commits into
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Important
The Studio overlay reordering is correct, but the PR also deletes a @ts-expect-error in packages/media-parser/src/writers/node.ts that is still load-bearing — it will break the media-parser typecheck, and it is unrelated to this fix. Please restore that line (details inline).
Reviewed changes
- SelectedOutlineRenderer — Split each outline's rendering into two passes: all polygons first, then all editing controls last, so a later-rendered polygon can no longer cover a previously rendered element's handles. Preserves the existing per-outline control ordering and the frozen drag ordering, and leaves the UV / transform-origin layers in place.
- SelectedOutlineElement — Added optional
renderControls/renderPolygonprops with defaultstrue, gating each pass. No behavior change for non-renderer callers (there are none besides the renderer). - media-parser/node.ts — Unrelated removal of
// @ts-expect-errorahead ofnew Blob([file]).
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix selected editing handles being covered by later-rendered polygons.
Issue
Fixes #10459
Changes