Skip to content

fix(vector-set): fall back to VRANDMEMBER when VRANGE is unavailable#6130

Merged
dantovska merged 1 commit into
mainfrom
ric/1.14
Jun 30, 2026
Merged

fix(vector-set): fall back to VRANDMEMBER when VRANGE is unavailable#6130
dantovska merged 1 commit into
mainfrom
ric/1.14

Conversation

@dantovska

@dantovska dantovska commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

What

Merge ric/1.14 back into main, bringing the one fix that landed on the release branch but isn't yet on main:

main is 20 commits ahead of ric/1.14; this PR's effective diff is just the above fix (4 files). Verified to merge cleanly — none of those files were modified on main since the merge-base.

Testing

Covered by the updated vector-set.service.spec.ts.


Note

Medium Risk
Changes browser vector-set listing behavior and error handling across Redis versions/proxies; misclassified errors could affect pagination vs fallback, but scope is limited to one service path with expanded tests.

Overview
Vector set element listing no longer uses RedisFeature.VRangeCommand / version checks. getElements delegates to listElementNames, which tries VRANGE first, then VRANDMEMBER only when Redis returns an unknown command error.

trySendCommand treats unsupported commands as a null reply so fallback can run; ACL, wrong-type, and other failures are rethrown (no silent fallback). If both list commands are missing, the API returns InternalServerErrorException with UNABLE_TO_LIST_VECTOR_SET_ELEMENTS.

RedisFeature.VRangeCommand is removed from redis.client.ts. Tests were updated for unknown-command fallback, no-fallback on permission errors, and the dual-failure case.

Reviewed by Cursor Bugbot for commit 326091f. Bugbot is set up for automated code reviews on this repo. Configure here.

…6118)

* fix(vector-set): fall back to VRANDMEMBER when VRANGE is unavailable
* fix(vector-set): only fall back to VRANDMEMBER on unsupported-command errors
@dantovska dantovska requested a review from a team as a code owner June 29, 2026 15:03
@dantovska dantovska self-assigned this Jun 29, 2026
@jit-ci

jit-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dantovska dantovska merged commit 655a242 into main Jun 30, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants