Conversation
…6118) * fix(vector-set): fall back to VRANDMEMBER when VRANGE is unavailable * fix(vector-set): only fall back to VRANDMEMBER on unsupported-command errors
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
KrumTy
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Merge
ric/1.14back intomain, bringing the one fix that landed on the release branch but isn't yet onmain:mainis 20 commits ahead ofric/1.14; this PR's effective diff is just the above fix (4 files). Verified to merge cleanly — none of those files were modified onmainsince the merge-base.Testing
Covered by the updated
vector-set.service.spec.ts.Note
Medium Risk
Changes browser vector-set listing behavior and error handling across Redis versions/proxies; misclassified errors could affect pagination vs fallback, but scope is limited to one service path with expanded tests.
Overview
Vector set element listing no longer uses
RedisFeature.VRangeCommand/ version checks.getElementsdelegates tolistElementNames, which triesVRANGEfirst, thenVRANDMEMBERonly when Redis returns an unknown command error.trySendCommandtreats unsupported commands as anullreply so fallback can run; ACL, wrong-type, and other failures are rethrown (no silent fallback). If both list commands are missing, the API returnsInternalServerErrorExceptionwithUNABLE_TO_LIST_VECTOR_SET_ELEMENTS.RedisFeature.VRangeCommandis removed fromredis.client.ts. Tests were updated for unknown-command fallback, no-fallback on permission errors, and the dual-failure case.Reviewed by Cursor Bugbot for commit 326091f. Bugbot is set up for automated code reviews on this repo. Configure here.