Skip to content

feat: AWS secret engine config and role types - #317

Open
marc-sensenich wants to merge 7 commits into
redhat-cop:mainfrom
marc-sensenich:feature/aws-secret-engine-types
Open

feat: AWS secret engine config and role types#317
marc-sensenich wants to merge 7 commits into
redhat-cop:mainfrom
marc-sensenich:feature/aws-secret-engine-types

Conversation

@marc-sensenich

@marc-sensenich marc-sensenich commented Apr 18, 2026

Copy link
Copy Markdown

Add new resources AWSSecretEngineConfig and AWSSecretEngineRole to support the management of AWS secret engine configuration and roles with the operator

@raffaelespazzoli raffaelespazzoli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the documentation page?

Comment thread api/v1alpha1/utils/vaultobject_test.go
@marc-sensenich
marc-sensenich marked this pull request as ready for review April 22, 2026 12:55
@marc-sensenich

Copy link
Copy Markdown
Author

@raffaelespazzoli documentation page updated in 996f755

@raffaelespazzoli

Copy link
Copy Markdown
Collaborator

there is an error in the mutating web hook. see the test-helmchart pipeline step.

@marc-sensenich

Copy link
Copy Markdown
Author

there is an error in the mutating web hook. see the test-helmchart pipeline step.

Resolved in 11b976d @raffaelespazzoli

@raffaelespazzoli

Copy link
Copy Markdown
Collaborator

there is still something failing in the helmchart

@marc-sensenich

Copy link
Copy Markdown
Author

@raffaelespazzoli test-helmchart is also failing on main, see https://github.com/redhat-cop/vault-config-operator/actions/runs/25901922480/job/76126952390. I took a look at this locally and wasn't able to reproduce the failures seen in GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants