Skip to content

Slightly more clear peer address resolvement#26

Open
WyriHaximus wants to merge 1 commit into
reactphp:1.xfrom
WyriHaximus-labs:slightly-more-clear-peer-address
Open

Slightly more clear peer address resolvement#26
WyriHaximus wants to merge 1 commit into
reactphp:1.xfrom
WyriHaximus-labs:slightly-more-clear-peer-address

Conversation

@WyriHaximus

Copy link
Copy Markdown
Member

This came up during a chat in a private channel where there was some confusion about how $peer was populated. This PR fixes that be returning an array() and pulling those into two variables again using list().

@clue clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this 👍 While I agree that the current solution is far from ideal, I'm not sure the suggested change actually improves this much.

However, I vote 👎 for this change simply because this is a BC break given the API is currently protected and this is (unfortunately) something consumers could potentially rely on.

@clue clue added the BC break label Oct 4, 2018
@WyriHaximus WyriHaximus added this to the v2.0.0 milestone Oct 4, 2018
@WyriHaximus

Copy link
Copy Markdown
Member Author

@clue assigned the milestone v2.0.0 for now. Are they any other breaking changes you would like to see? I have two more weeks off, I'm sure I can spent some time on those 😄

@clue

clue commented Oct 5, 2018

Copy link
Copy Markdown
Member

@WyriHaximus I don't see anything on the roadmap for this component at the moment, so I'm not sure a v2.0.0 is something that is due any time soon?

This component is lacking documentation, so perhaps that's also what caused some of the confusion for people trying to make sense of the internal parameters. It's my understanding that some consumer facing documentation both as part of the class hierarchy and the README would help here 👍

@WyriHaximus

Copy link
Copy Markdown
Member Author

@clue correct, so I made the milestone for anything we might want to have in there.

I'll look into that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants