refactor: evolve salt into raystack service framework

.github/workflows/lint.yaml

@@ -24,6 +24,6 @@ jobs:
         with:
           go-version-file: "go.mod"
       - name: Run linter
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.60
+          version: v2.11

.golangci.yml

@@ -1,24 +1,21 @@
-output:
-  formats:
-    - format: line-number
+version: "2"
+formatters:
+  enable:
+    - goimports
+    - gofmt
 linters:
-  enable-all: false
-  disable-all: true
+  disable:
+    - errcheck
   enable:
     - govet
-    - goimports
     - thelper
     - tparallel
     - unconvert
     - wastedassign
     - revive
     - unused
-    - gofmt
     - whitespace
     - misspell
-linters-settings:
-  revive:
-    ignore-generated-header: true
-    severity: warning
-severity:
-  default-severity: error
+  settings:
+    revive:
+      severity: warning

MIGRATION.md

@@ -0,0 +1,328 @@
+# Migration Guide
+
+This guide covers migrating from the previous salt version to the new structure.
+
+## Go version
+
+Update `go.mod` to require Go 1.24:
+
+```
+go 1.24
+```
+
+## Packages removed
+
+| Removed | Replacement |
+|---------|-------------|
+| `observability/logger` | Use `*slog.Logger` from `log/slog` directly |
+| `observability/otelgrpc` | Use `connectrpc.com/otelconnect` |
+| `observability/otelhttpclient` | Use `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` |
+| `server/mux` | Use `github.com/raystack/salt/server` |
+| `db` | Use your preferred DB library (sqlx, pgx, gorm) directly |
+| `auth/oidc` | Planned as complete CLI auth solution (#86) |
+| `auth/audit` | Planned with standardized schema (#87) |
+| `testing/dockertestx` | Use `ory/dockertest/v3` directly |
+
+## Packages moved
+
+| Old | New |
+|-----|-----|
+| `observability` | `telemetry` |
+| `cli/terminator` | `cli/terminal` |
+| `cli/prompter` | `cli/prompt` |
+| `cli/releaser` | `cli/version` |
+
+## Logger
+
+The custom `logger.Logger` interface and all backends (Zap, Logrus, Slog, Noop) are removed. Use `*slog.Logger` from the Go standard library directly.
+
+```go
+// Before
+import "github.com/raystack/salt/observability/logger"
+l := logger.NewZap()
+l := logger.NewLogrus()
+l := logger.NewNoop()
+
+// After
+import "log/slog"
+l := slog.Default()
+l := slog.New(slog.NewJSONHandler(os.Stderr, nil))
+l := slog.New(slog.DiscardHandler) // noop
+```
+
+All salt packages that previously accepted `logger.Logger` now accept `*slog.Logger`.
+
+## Server
+
+The dual-port `server/mux` package is replaced by a single-port `server` package with h2c support.
+
+```go
+// Before
+import "github.com/raystack/salt/server/mux"
+mux.Serve(ctx,
+    mux.WithHTTPTarget(":8080", httpServer),
+    mux.WithGRPCTarget(":8081", grpcServer),
+)
+
+// After
+import "github.com/raystack/salt/server"
+srv := server.New(
+    server.WithAddr(":8080"),
+    server.WithHandler("/api/", connectHandler),
+)
+srv.Start(ctx)
+```
+
+H2C and health check (`/ping`) are enabled by default. Use `server.WithoutH2C()` or `server.WithHealthCheck("")` to disable.
+
+## App bootstrap
+
+New `app.Run()` for service bootstrap:
+
+```go
+import "github.com/raystack/salt/app"
+
+app.Run(
+    app.WithConfig(&cfg, config.WithFile("config.yaml")),
+    app.WithLogger(slog.Default()),
+    app.WithHTTPMiddleware(middleware.DefaultHTTP(slog.Default())),
+    app.WithHandler("/api/", handler),
+    app.WithAddr(cfg.Addr),
+)
+```
+
+HTTP middleware is explicit — use `middleware.DefaultHTTP(logger)` for the standard chain or compose your own. Database connections are managed via `app.WithOnStart` / `app.WithOnStop` hooks.
+
+## CLI bootstrap
+
+`cli.Init()` enhances your root command with standard features and `cli.Execute()` runs it with proper error handling:
+
+```go
+// Before
+rootCmd := &cobra.Command{Use: "frontier", Short: "identity management"}
+mgr := commander.New(rootCmd, commander.WithTopics(topics))
+mgr.Init()
+rootCmd.AddCommand(serverCmd, configCmd)
+
+cmd, err := rootCmd.ExecuteC()
+if err != nil {
+    if commander.IsCommandErr(err) {
+        fmt.Println(cmd.UsageString())
+    }
+    fmt.Println(err)
+    os.Exit(1)
+}
+
+// After
+import "github.com/raystack/salt/cli"
+
+rootCmd := &cobra.Command{Use: "frontier", Short: "identity management"}
+rootCmd.PersistentFlags().StringP("host", "h", "", "API host")
+rootCmd.AddCommand(serverCmd, configCmd)
+
+cli.Init(rootCmd,
+    cli.Version("0.1.0", "raystack/frontier"),
+    cli.Topics(topics...),
+)
+
+cli.Execute(rootCmd)
+```
+
+Config command helper replaces boilerplate:
+
+```go
+// Before (50 lines of config init/list commands)
+cmd.AddCommand(configInitCommand())
+cmd.AddCommand(configListCommand())
+
+// After (1 line)
+rootCmd.AddCommand(cli.ConfigCommand("frontier", &Config{}))
+```
+
+Command grouping uses cobra's native GroupID instead of annotations:
+
+```go
+// Before
+cmd.Annotations = map[string]string{"group": "core"}
+
+// After
+rootCmd.AddGroup(&cobra.Group{ID: "manage", Title: "Management:"})
+cmd.GroupID = "manage"
+```
+
+Access shared output and prompting in commands:
+
+```go
+func newListCmd() *cobra.Command {
+    return &cobra.Command{
+        Use: "list",
+        RunE: func(cmd *cobra.Command, args []string) error {
+            out := cli.Output(cmd)
+            out.Table(rows)
+            return nil
+        },
+    }
+}
+```
+
+## Error handling
+
+`commander.IsCommandErr` (string matching) and manual error handling are replaced by `cli.Execute`:
+
+```go
+// Before
+if err := rootCmd.Execute(); err != nil {
+    if commander.IsCommandErr(err) {
+        // show usage
+    }
+    fmt.Fprintln(os.Stderr, err)
+    os.Exit(1)
+}
+
+// After
+cli.Execute(rootCmd) // handles all errors with proper exit codes
+```
+
+`cli.Execute` uses `ExecuteC` internally and handles all error types:
+
+| Error | Behavior |
+|-------|----------|
+| `cli.ErrSilent` | Exit 1, no output (command already printed the error) |
+| `cli.ErrCancel` | Exit 0, no output (user cancelled) |
+| Flag errors | Prints error + failing command's usage, exit 1 |
+| Other errors | Prints "Error: \<message\>", exit 1 |
+
+In commands, return sentinel errors to control exit behavior:
+
+```go
+// Command already printed a rich error — exit 1, no extra output
+out.Error("connection failed: timeout")
+return cli.ErrSilent
+
+// User cancelled (ctrl-c, declined prompt) — exit 0
+return cli.ErrCancel
+```
+
+The following exports are removed — their functionality is now internal to `cli.Execute`:
+
+| Removed | Replacement |
+|---------|-------------|
+| `cli.HandleError(err)` | `cli.Execute(rootCmd)` handles errors automatically |
+| `cli.NewFlagError(err)` | `cli.Init` wraps flag errors automatically via `SetFlagErrorFunc` |
+| `cli.FlagError` (type) | Unexported; flag errors are handled internally by `Execute` |
+| `commander.IsCommandErr(err)` | Removed; `Execute` detects and handles flag/command errors |
+
+## Printer
+
+Package-level functions replaced by `Output` type:
+
+```go
+// Before
+printer.Success("done")
+printer.Table(os.Stdout, rows)
+printer.JSON(data)
+spinner := printer.Spin("loading")
+
+// After
+out := printer.NewOutput(os.Stdout)
+// or inside a command: out := cli.Output(cmd)
+
+out.Success("done")
+out.Table(rows)
+out.JSON(data)
+spinner := out.Spin("loading")
+```
+
+Color formatting functions remain as package-level helpers returning styled strings:
+
+```go
+printer.Green("text")
+printer.Greenf("count: %d", n)
+printer.Icon("success") // ✔
+printer.Italic("note")
+```
+
+## Telemetry
+
+```go
+// Before
+import "github.com/raystack/salt/observability"
+observability.Init(ctx, cfg, logger)
+
+// After
+import "github.com/raystack/salt/telemetry"
+telemetry.Init(ctx, cfg, slogLogger)
+```
+
+## Middleware
+
+New package for ConnectRPC and HTTP middleware:
+
+```go
+import "github.com/raystack/salt/middleware"
+
+// Connect interceptors for your handler
+interceptors := middleware.Default(slog.Default())
+handler := myv1connect.NewServiceHandler(svc, connect.WithInterceptors(interceptors...))
+
+// HTTP middleware
+httpMW := middleware.DefaultHTTP(slog.Default())
+```
+
+## Config
+
+```go
+// Import path for validator changed
+// Before: "github.com/go-playground/validator"
+// After:  "github.com/go-playground/validator/v10"
+
+// If you imported go-defaults directly:
+// Before: "github.com/mcuadros/go-defaults"
+// After:  "github.com/creasty/defaults"
+// API change: defaults.SetDefaults(cfg) → defaults.Set(cfg)
+```
+
+The config package no longer prints warnings to stdout when a config file is missing.
+
+## Version package
+
+`cli/version` now exports only `CheckForUpdate`. The functions `FetchInfo`, `CompareVersions`, and types `Info`, `Timeout`, `APIFormat` are no longer exported — they were internal implementation details.
+
+## Dependency changes
+
+| Removed (direct) | Replacement |
+|-------------------|-------------|
+| `go.uber.org/zap` | `log/slog` (stdlib) |
+| `sirupsen/logrus` | `log/slog` (stdlib) |
+| `AlecAivazis/survey/v2` | `charmbracelet/huh` |
+| `olekukonko/tablewriter` | `text/tabwriter` (stdlib) |
+| `oklog/run` | Removed with `server/mux` |
+| `cli/safeexec` | `exec.LookPath` (stdlib) |
+| `pkg/errors` | `fmt.Errorf` with `%w` (stdlib) |
+| `mcuadros/go-defaults` | `creasty/defaults` |
+| `go-playground/validator` v9 | `go-playground/validator/v10` |
+| `jmoiron/sqlx` | Use directly if needed |
+| `golang-migrate` | Use directly if needed |
+| `ory/dockertest` | Use directly if needed |
+
+| Added | Purpose |
+|-------|---------|
+| `connectrpc.com/connect` | Middleware interceptors |
+| `charmbracelet/huh` | Interactive prompts |
+| `creasty/defaults` | Struct default values |
+
+| Upgraded | From → To |
+|----------|-----------|
+| `spf13/cobra` | v1.8.1 → v1.10.2 |
+| `spf13/pflag` | v1.0.5 → v1.0.10 |
+| `spf13/viper` | v1.19.0 → v1.21.0 |
+| `go-playground/validator` | v9 → v10 |
+| `charmbracelet/glamour` | v0.3 → v1.0.0 |
+| `muesli/termenv` | v0.11 → v0.16.0 |
+| `briandowns/spinner` | v1.18 → v1.23.2 |
+| `schollz/progressbar` | v3.8 → v3.19.0 |
+| `mattn/go-isatty` | v0.0.19 → v0.0.21 |
+| `opentelemetry/otel` | v1.31.0 → v1.43.0 |
+| `google.golang.org/grpc` | v1.67.1 → v1.80.0 |
+| `stretchr/testify` | v1.9.0 → v1.11.1 |
+| `hashicorp/go-version` | v1.3.0 → v1.9.0 |