-
Notifications
You must be signed in to change notification settings - Fork 13
fix(amount): added bigInt and hideCurrency support in amount component #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shreyag02
wants to merge
7
commits into
main
Choose a base branch
from
fix/amount/bigInt-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+282
−37
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fe87575
fix(amount): added bigInt and hideCurrency support in amount component
Shreyag02 4bd4039
updates to resolve comments
Shreyag02 197a738
updates to resolve comments
Shreyag02 43b4425
simplifying hidecurrency logic
Shreyag02 6c9a6a7
minor updates
Shreyag02 adc6c70
linting updates
Shreyag02 dd559e1
simplify intl v3 precision warning, drop runtime probe
Shreyag02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,18 @@ | ||
| export interface AmountProps { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| /** | ||
| * The monetary value to display | ||
| * For large numbers (> 2^53), pass the value as string to maintain precision | ||
| * The monetary value to display. | ||
| * For exact precision beyond 2^53, pass either: | ||
| * - a `string` — supports decimals (e.g. "1299" or "12.99") | ||
| * - a `bigint` — integer-only; treated as already in major units, so | ||
| * `valueInMinorUnits` is ignored when value is a bigint | ||
| * @default 0 | ||
| * @example | ||
| * valueInMinorUnits=true: 1299 => "$12.99" | ||
| * valueInMinorUnits=false: 12.99 => "$12.99" | ||
| * Large numbers: "999999999999999" => "$9,999,999,999,999.99" | ||
| * Large strings: "999999999999999" => "$9,999,999,999,999.99" | ||
| * BigInt: 1299n => "$1,299.00" (always major units) | ||
| */ | ||
| value: number | string; | ||
| value: number | string | bigint; | ||
|
|
||
| /** | ||
| * ISO 4217 currency code | ||
|
|
@@ -65,4 +69,14 @@ export interface AmountProps { | |
| * @default true | ||
| */ | ||
| groupDigits?: boolean; | ||
|
|
||
| /** | ||
| * Render the formatted number without a currency symbol, code, or name. | ||
| * Locale-driven separators, grouping, and fraction digits are preserved. | ||
| * When true, `currencyDisplay` is ignored. | ||
| * @default false | ||
| * @example | ||
| * <Amount value={1299} hideCurrency /> => "12.99" | ||
| */ | ||
| hideCurrency?: boolean; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valueInMinorUnits={false}can be removed from here as its contradicting.valueInMinorUnitsis ignored if large value is passed to value prop.