fix(ci): resolve all zizmor findings and add zizmor pre-commit checks#475
Open
gforsyth wants to merge 6 commits intorapidsai:mainfrom
Open
fix(ci): resolve all zizmor findings and add zizmor pre-commit checks#475gforsyth wants to merge 6 commits intorapidsai:mainfrom
gforsyth wants to merge 6 commits intorapidsai:mainfrom
Conversation
33 tasks
jakirkham
reviewed
May 7, 2026
Member
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Gil! 🙏
Generally this looks reasonable
Had one minor style question. Though no strong feelings on it
Comment on lines
+32
to
+33
| env: | ||
| INPUTS_TOOL_CACHE: ${{ inputs.tool_cache }} |
Member
There was a problem hiding this comment.
Would it make sense to move this above shell as is done in the other case?
Author
There was a problem hiding this comment.
No strong feelings, so I moved it for consistency. Thanks!
jakirkham
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to upstream changes in
shared-workflows, this PR cleans up and annotates all of the workflows and adds thezizmorlinter to make sure changes are checked.Part of rapidsai/build-planning#275