Skip to content

feat: allow variable object sizes - #18

Open
BrennaEpp wants to merge 1 commit into
raj-prince:mainfrom
BrennaEpp:variable-obj-size
Open

feat: allow variable object sizes#18
BrennaEpp wants to merge 1 commit into
raj-prince:mainfrom
BrennaEpp:variable-obj-size

Conversation

@BrennaEpp

Copy link
Copy Markdown
Contributor

allow passing in part of the object prefix

Also reorders the vars so that flags are grouped together.

allow passing in part of the object prefix
raj-prince
raj-prince previously approved these changes Oct 29, 2024
@raj-prince
raj-prince requested review from raj-prince and removed request for raj-prince October 29, 2024 13:48
@raj-prince
raj-prince dismissed their stale review October 29, 2024 13:48

One comment.

Comment thread main.go
retryMultiplier = 2.0

// MB means 1024 Kb.
MB = 1024 * 1024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this unused?

Comment thread main.go
grpcConnPoolSize = 1
maxConnsPerHost = 100
maxIdleConnsPerHost = 100
MiB = 1024 * 1024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we fix this audit error?

@raj-prince

Copy link
Copy Markdown
Owner

Can we use --obj-prefix and --obj-suffix here?
Supported with this PR: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants