By @Ayanda-D: Multiple channel interceptors, with a core team follow-up (backport #17182) - #17188
Open
mergify[bot] wants to merge 19 commits into
Open
By @Ayanda-D: Multiple channel interceptors, with a core team follow-up (backport #17182)#17188mergify[bot] wants to merge 19 commits into
mergify[bot] wants to merge 19 commits into
Conversation
using different configured priority levels. Only disallow channel interceptors for the same AMQP operation when they have the same configured priority level. (cherry picked from commit 8847a37)
…configs (cherry picked from commit 13249f2)
(cherry picked from commit d500ce1) # Conflicts: # deps/rabbit/test/channel_interceptor_SUITE.erl
channel interceptors with their configured meta information (cherry picked from commit cc90446)
(cherry picked from commit d7f6c37)
rabbit/src with behaviour dependencies (cherry picked from commit 4efc635)
to set priority levels for channel interceptor (modules) (cherry picked from commit af030be)
and update/fix manual merge update (cherry picked from commit 2b9101d)
and optimize application:get_env/1 lookups to be only called once before comparing priorities in init/1 and listing in list/0 (cherry picked from commit dc0a521)
to clarify that interceptor priorities set are not persisted and will not survive node restarts (cherry picked from commit 3323180)
only terminate list/0 for any other non-channel interceptor module causing a crash. also update formatting for error messages to be more detailed to include 'priority, modules and operations' on conflicting interceptors. (cherry picked from commit dcde0c7)
to list of ENABLED_PLUGINS in rabbitmq_cli/Makefile to register the rabbit_sharding_interceptor on the running node ensuring a real, loaded channel interceptor is available for CLI tests. (cherry picked from commit bbedbd0)
…tered interceptor at boot (cherry picked from commit 1c04fb5)
error responses to {:validation_failure, {:bad_argument, _}} to
ensure these exit with 65 and print usage
(cherry picked from commit 6a43bea)
(cherry picked from commit ba3e4a1)
…ions (cherry picked from commit 13a3757)
…g dummy_interceptor back to /test) (cherry picked from commit df93d49)
A `meck`-based version turned out to be simpler. (cherry picked from commit 13e2b6d)
Author
|
Cherry-pick of d500ce1 has failed: Cherry-pick of b29b6e6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Author
|
Tick the box to add this pull request to the merge queue (same as
|
4.3.5: By @Ayanda-D: Multiple channel interceptors, with a core team follow-up (backport #17182)
4.3.5: By @Ayanda-D: Multiple channel interceptors, with a core team follow-up (backport #17182)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #16046 by @Ayanda-D and other contributors, plus a few tweaks from me, mostly around naming, test coverage and edge case handling.
Backporting
Backport PR must wait for the
4.3.5release to ship first.This is an automatic backport of pull request #17182 done by Mergify.