Vectorize get_fixed_string - #3103
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## string-boundary-metadata #3103 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 129 129
Lines 7487 7483 -4
==========================================================
- Hits 7487 7483 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MichaelChirico
force-pushed
the
vectorize-get-fixed
branch
from
August 21, 2026 04:55
4ff3ba1 to
539470b
Compare
MichaelChirico
force-pushed
the
vectorize-get-fixed
branch
from
August 21, 2026 06:40
539470b to
d345fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3102 re-uses this, and in both sites,
encodeString()wraps the output.I wanted to absorb this
encodeString()call to the helper, and found the natural way to do so to vectorize the loop (an alternative is to split into two helpers, one to get a fixed regex from a single string, the other wrapping that).