refactor: drop the need to use importlib#61
Open
12rambau wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reach the file system you are using
importlib.resourceswhich is basically reading the file tree that exists within the wheel. I was trying to restore functionalities of ee_extra in geetools and I got many failures related to this mechanism (https://github.com/gee-community/geetools/actions/runs/16901688812/job/47882812551?pr=467)I don't really know how to debug this and I personnaly think relying on importlib is an overkill. In this PR I propose a method that only rely on pathlib to find all the files we need to perform the computation. It will work just as pckg_resources as long as you are not editing the pakg file names when building the wheel (whic is not the case now)