Skip to content

Reject out-of-range limits in Iterator.prototype.take/drop #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saghul merged 2 commits into from
Jul 30, 2026
+12 −23
Merged

Reject out-of-range limits in Iterator.prototype.take/drop #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0baadf0
Update test262
saghul Jul 30, 2026
c9552eb
Reject out-of-range limits in Iterator.prototype.take/drop
saghul Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45387,30 +45387,16 @@ static JSValue js_create_iterator_helper(JSContext *ctx, JSValueConst this_val,
v = JS_ToNumber(ctx, argv[0]);
if (JS_IsException(v))
goto fail;
// Check for Infinity.
if (JS_ToFloat64(ctx, &dlimit, v)) {
JS_FreeValue(ctx, v);
goto fail;
}
if (isnan(dlimit)) {
JS_FreeValue(ctx, v);
JS_ToFloat64Free(ctx, &dlimit, v);
if (isnan(dlimit))
goto range_error;
}
if (!isfinite(dlimit)) {
JS_FreeValue(ctx, v);
if (dlimit < 0)
goto range_error;
else
count = MAX_SAFE_INTEGER;
} else {
v = JS_ToIntegerFree(ctx, v);
if (JS_IsException(v))
goto fail;
if (JS_ToInt64Free(ctx, &count, v))
goto fail;
}
if (count < 0)
if (isfinite(dlimit) && dlimit > MAX_SAFE_INTEGER)
goto range_error;
dlimit = trunc(dlimit);
if (dlimit < 0)
goto range_error;
// +Infinity means "no limit"; use MAX_SAFE_INTEGER
count = isfinite(dlimit) ? (int64_t)dlimit : MAX_SAFE_INTEGER;
}
break;
case JS_ITERATOR_HELPER_KIND_FILTER:
Expand Down
2 changes: 1 addition & 1 deletion test262
Open in desktop
Submodule test262 updated 188 files
3 changes: 3 additions & 0 deletions test262.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,10 @@ Intl.NumberFormat-v3=skip
Intl.RelativeTimeFormat=skip
Intl.Segmenter=skip
IsHTMLDDA
Iterator.prototype.join=skip
iterator-chunking=skip
iterator-helpers
iterator-includes=skip
iterator-sequencing
joint-iteration
json-modules
Expand Down
Loading