Support resizable externally managed ArrayBuffers - #1594
Merged
Conversation
saghul
commented
Jul 21, 2026
sigmaraz
reviewed
Jul 21, 2026
Contributor
Author
|
@bnoordhuis can you PTAL? |
bnoordhuis
reviewed
Jul 24, 2026
Contributor
Author
|
@bnoordhuis PTAL. Sorry for the back and forth on this one. I had a new idea in the shower today, which I think solves all problems: actually support externally managed RABs. I did so by turning that free_func into a realloc_func (a single allocation function like we use elsewhere like lre), so externally managed buffers can be resized no problem. |
saghul
force-pushed
the
ab-transfer-fix
branch
2 times, most recently
from
July 30, 2026 07:28
658d676 to
65df479
Compare
saghul
changed the title
Replace the free-only callback for externally managed ArrayBuffer data:
typedef void JSFreeArrayBufferDataFunc(JSRuntime *rt, void *opaque,
void *ptr);
with a realloc style one, which can both resize and free:
typedef void *JSReallocArrayBufferDataFunc(JSRuntime *rt, void *opaque,
void *ptr, size_t size);
JS_NewArrayBuffer() grows a max_len parameter so external resizable
ArrayBuffers can actually be created; zero means not resizable.
Externally managed SharedArrayBuffers are exempt from the realloc
function requirement: growable SABs commit their maximum size upfront and
are never reallocated, so 'buf' must simply be max_len bytes big.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.