feat: Constant duplication#4257
Open
narendasan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
component: tests
narendasan
force-pushed
the
push-zupxwwusykto
branch
from
e7b4139 to
304fc36
Compare
narendasan
commented
May 12, 2026
| DYNAMICALLY_ALLOCATE_RESOURCES = False | ||
| DECOMPOSE_ATTENTION = False | ||
| ATTN_BIAS_IS_CAUSAL = True | ||
| CONSTANT_DUPLICATION = False |
Collaborator
Author
There was a problem hiding this comment.
I think we can flip this if TRT is able to catch the identical weights
…aphs with common constants in to seperate trees to provide more opportunities for constant folding
narendasan
force-pushed
the
push-zupxwwusykto
branch
from
304fc36 to
23a8b46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Duplicate weights in order to split subgraphs with common constants in to separate trees to provide more opportunities for constant folding
Fixes #4234
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: