Skip to content

fix tarball copy issue#4252

Open
lanluo-nvidia wants to merge 1 commit into
mainfrom
lluo/fix_wheel_issue
Open

fix tarball copy issue#4252
lanluo-nvidia wants to merge 1 commit into
mainfrom
lluo/fix_wheel_issue

Conversation

@lanluo-nvidia
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this May 12, 2026
@meta-cla meta-cla Bot added the cla signed label May 12, 2026
@github-actions github-actions Bot added the component: build system Issues re: Build system label May 12, 2026
@github-actions github-actions Bot requested a review from narendasan May 12, 2026 02:15
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review May 12, 2026 06:03
@narendasan
Copy link
Copy Markdown
Collaborator

I still think any c++ source files we ship in the wheels or tarballs should be in a subdirectory called src/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants