gh-148093: Raise binascii.Error from binascii.a2b_uu on empty input#149077
Open
maurycy wants to merge 6 commits intopython:mainfrom
Open
gh-148093: Raise binascii.Error from binascii.a2b_uu on empty input#149077maurycy wants to merge 6 commits intopython:mainfrom
binascii.Error from binascii.a2b_uu on empty input#149077maurycy wants to merge 6 commits intopython:mainfrom
Conversation
Contributor
Author
sethmlarson
reviewed
Apr 27, 2026
| self.assertRaises(binascii.Error, binascii.a2b_uu, b"!!!!") | ||
| self.assertRaises(binascii.Error, binascii.a2b_uu, | ||
| self.type2test(b"")) | ||
| self.assertRaises(binascii.Error, binascii.a2b_uu, |
Contributor
There was a problem hiding this comment.
Do we need this second test case? The [:0] makes it an empty sequence?
Contributor
Author
There was a problem hiding this comment.
cpython/Lib/test/test_binascii.py
Lines 1622 to 1623 in 005555a
memoryview(b"#86)C")[:0] is the actual UB case here: zero slice with larger underlying buffer
@serhiy-storchaka came up with it:
Truth to be told, this BinASCIITest inheritance is very confusing and make lots of tests without self.type2test redundant but I didn't want to overhaul it. Do you want me to create a separate issue documenting problems with BinASCIITest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
binascii.a2b_uuwith empty data reads one byte past the end of the input buffer. Per the discussion, it should raisebinascii.Error.Resolves #148093