gh-148887: Remove version hardcoding in Tools/pixi-packages#148890
Open
isuruf wants to merge 1 commit intopython:mainfrom
Open
gh-148887: Remove version hardcoding in Tools/pixi-packages#148890isuruf wants to merge 1 commit intopython:mainfrom
isuruf wants to merge 1 commit intopython:mainfrom
Conversation
hugovk
reviewed
Apr 22, 2026
|
|
||
| context: | ||
| # Keep up to date | ||
| version: ${{ git.latest_tag(".")[1:] }} |
Member
There was a problem hiding this comment.
The tags start with v, for example: v3.15.0a8. Does that need stripping?
Also, in two weeks, we'll branch main to a 3.15 branch, and main will become the home for 3.16.
There won't be any 3.16 tags until October.
https://peps.python.org/pep-0826/
Will that cause a problem?
Contributor
Author
There was a problem hiding this comment.
The tags start with v, for example: v3.15.0a8. Does that need stripping?
Yes, I've stripped v by doing [1:].
There won't be any 3.16 tags until October.
Yes, that'll cause an issue if git describe --tags shows 3.15 instead of 3.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148887 by using an experimental feature in rattler-build
cc @crusaderky @hugovk @ngoldbaum