Skip to content

Add skip-news to test only PRs #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add skip-news to test only PRs #670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f9ee2d
Commit
StanFromIreland Sep 8, 2025
22a76bd
Commit
StanFromIreland Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bedevere/prtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ async def classify_by_filepaths(gh, pull_request, filenames):
return pr_labels
if tests:
pr_labels = [Labels.tests]
if not news and not docs:
pr_labels.append(Labels.skip_news)
elif docs:
if news:
pr_labels = [Labels.docs]
Comment thread
StanFromIreland marked this conversation as resolved.
Outdated
Expand Down
10 changes: 6 additions & 4 deletions tests/test_filepaths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,12 @@ async def test_tests_only(author_association):
gh.getiter_url == "https://api.github.com/repos/cpython/python/pulls/1234/files"
)
assert gh.getitem_url == "https://api.github.com/repos/cpython/python/issue/1234"
assert len(gh.post_url) == 3 if author_association == "NONE" else 2
assert len(gh.post_url) == 1
assert gh.post_url.pop(0) == "https://api.github.com/some/label"
assert gh.post_data.pop(0) == [Labels.tests.value]
check_n_pop_nonews_events(gh, author_association == "NONE")
assert gh.post_data.pop(0) == [Labels.tests.value, Labels.skip_news.value]
# Don't post any comment
assert gh.post_url == []
assert gh.post_data == []


async def test_docs_and_tests():
Expand Down Expand Up @@ -176,7 +178,7 @@ async def test_docs_and_tests():
gh.getiter_url == "https://api.github.com/repos/cpython/python/pulls/1234/files"
)
assert gh.getitem_url == "https://api.github.com/repos/cpython/python/issue/1234"
# Only creates type-tests label.
# Only creates tests label.
assert len(gh.post_url) == 2
assert gh.post_url[0] == "https://api.github.com/some/label"
assert gh.post_data[0] == [Labels.tests.value]
Expand Down
4 changes: 2 additions & 2 deletions tests/test_prtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ async def test_tests_only():
assert gh.getitem_url == "https://api.github.com/repos/cpython/python/issue/1234"
assert len(gh.post_url) == 1
assert gh.post_url[0] == "https://api.github.com/some/label"
assert gh.post_data[0] == [Labels.tests.value]
assert gh.post_data[0] == [Labels.tests.value, Labels.skip_news.value]


async def test_tests_and_testmods_only():
Expand All @@ -162,7 +162,7 @@ async def test_tests_and_testmods_only():
assert gh.getitem_url == "https://api.github.com/repos/cpython/python/issue/1234"
assert len(gh.post_url) == 1
assert gh.post_url[0] == "https://api.github.com/some/label"
assert gh.post_data[0] == [Labels.tests.value]
assert gh.post_data[0] == [Labels.tests.value, Labels.skip_news.value]


async def test_docs_and_tests():
Expand Down
Loading