Initial draft revision of IRENA - #51
Draft
davide-f wants to merge 1 commit into
Draft
Conversation
ekatef
reviewed
Jun 15, 2026
ekatef
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @davide-f. Providing a preliminary feedback as requested.
I very much like disentangling of data specification from the code this approach implements. My major comment relates to naming. Harmonisation is not too specific and can mean plenty of things. E.g. data harmonisation can be perceived as enforcing some generic data format while the actual idea is rather regional-specific tailoring (if I get it right).
Also, a part on unmapped technologies may deserve some additional attention to cross-check the behaviour makes sense from the users' perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config.yaml.doc/release-notes.mdis amended in the format of previous release notes, including reference to the requested PR.