Skip to content

Initial draft revision of IRENA - #51

Draft
davide-f wants to merge 1 commit into
pypsa-meets-earth:mainfrom
davide-f:generalize_filter_IRENA
Draft

Initial draft revision of IRENA#51
davide-f wants to merge 1 commit into
pypsa-meets-earth:mainfrom
davide-f:generalize_filter_IRENA

Conversation

@davide-f

Copy link
Copy Markdown
Member

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented, including updates to docstrings for meaningful functions.
  • Newly introduced dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.yaml.
  • A note for the release notes doc/release-notes.md is amended in the format of previous release notes, including reference to the requested PR.

@ekatef ekatef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @davide-f. Providing a preliminary feedback as requested.

I very much like disentangling of data specification from the code this approach implements. My major comment relates to naming. Harmonisation is not too specific and can mean plenty of things. E.g. data harmonisation can be perceived as enforcing some generic data format while the actual idea is rather regional-specific tailoring (if I get it right).

Also, a part on unmapped technologies may deserve some additional attention to cross-check the behaviour makes sense from the users' perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

2 participants