Fix: Errors generated from invalid xrefs should fail build#300
Merged
hoodmane merged 1 commit intopyodide:masterfrom Mar 30, 2026
Merged
Fix: Errors generated from invalid xrefs should fail build#300hoodmane merged 1 commit intopyodide:masterfrom
hoodmane merged 1 commit intopyodide:masterfrom
Conversation
hoodmane
force-pushed
the
invalid-xref-errors
branch
from
ed97ec7 to
3ca2c54
Compare
Previously, if `ts_type_xref_formatter` generated a bad xref, it would not fail the build because the error reporter for the subdocument tree was not hooked up to the top level error reporter. This also fixes the line numbers reported in the errors.
hoodmane
force-pushed
the
invalid-xref-errors
branch
from
3ca2c54 to
230011d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
ts_type_xref_formattergenerated a bad xref, it would not fail the build because the error reporter for the subdocument tree was not hooked up to the top level error reporter. This also fixes the line numbers reported in the errors.