Make sure load_package() fails when a url returns a 404#184
Merged
hoodmane merged 2 commits intopyodide:mainfrom Apr 21, 2026
Merged
Make sure load_package() fails when a url returns a 404#184hoodmane merged 2 commits intopyodide:mainfrom
load_package() fails when a url returns a 404#184hoodmane merged 2 commits intopyodide:mainfrom
Conversation
ryanking13
approved these changes
Apr 21, 2026
Comment on lines
+321
to
+323
| # * For a known-but-unresolvable package (e.g. a wheel URL that | ||
| # 404s), the returned promise resolves normally and the failure | ||
| # is only delivered via the ``errorCallback`` option. |
Member
There was a problem hiding this comment.
(No actions required for this PR)
I wonder if we should change this behavior. I am not sure why we designed in that way at the first place.
I guess it was when loadPackage was unstable, we wanted a failure in a single package resolution failure does not block loading other packages. But now, I guess it is weird to make loadPackage silently success even when the package load fails.
agriyakhetarpal
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.