Fix docs mentioning that index URLs must support JSON API (they do not)#274
Merged
hoodmane merged 3 commits intopyodide:mainfrom Apr 30, 2026
Merged
Fix docs mentioning that index URLs must support JSON API (they do not)#274hoodmane merged 3 commits intopyodide:mainfrom
hoodmane merged 3 commits intopyodide:mainfrom
Conversation
ryanking13
reviewed
Apr 30, 2026
Comment on lines
+136
to
+137
| - The index URL must support CORS when used in a web browser. Note that \ | ||
| *https://pypi.org/simple* has CORS enabled. |
Member
There was a problem hiding this comment.
Suggested change
| - The index URL must support CORS when used in a web browser. Note that \ | |
| *https://pypi.org/simple* has CORS enabled. | |
| - The index URL must support CORS when used in a web browser. |
Sounds redundant to me.
Comment on lines
125
to
126
| - The index URL may support the \ | ||
| `JSON API <https://warehouse.pypa.io/api-reference/json/>`__ . |
Member
There was a problem hiding this comment.
Let's just say that the remote index should support Simple repository API. We support JSON api but it is not standardized so I don't really want to let users know about it. We may drop supporting it later.
Comment on lines
128
to
131
| - The index URL may contain the placeholder {package_name}, for example \ | ||
| *https://pypi.org/pypi/{package_name}/json*, this placeholder will be \ | ||
| replaced with the package name when looking up a package. If it does not \ | ||
| contain the placeholder, the package name will be appended to the URL. |
Member
There was a problem hiding this comment.
Let's also remove this as well.
alexprengere
force-pushed
the
docs/indexurls
branch
from
6eee80f to
ecae53d
Compare
alexprengere
force-pushed
the
docs/indexurls
branch
from
c89af20 to
6ed470c
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
I pushed the suggestions. I also changed similar things in |
hoodmane
reviewed
Apr 30, 2026
Member
hoodmane
left a comment
hoodmane
left a comment
There was a problem hiding this comment.
Revert test formatting changes.
Member
I think they are done by pre-commit.ci for some reason |
Contributor
Author
|
Yeah I did not push those, and I did not configure precommit locally so this is coming from the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273