Fix TypedListConstant.signature() being unhashable and uncomparable - #2307
Open
Sanjays2402 wants to merge 1 commit into
Open
Fix TypedListConstant.signature() being unhashable and uncomparable#2307Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
TypedListConstant inherited the base Constant.signature(), which returns (self.type, self.data). For a typed list, data is a Python list of arrays, so the signature raised on both of the operations it exists to support: c1.signature() == c2.signature() -> ValueError: truth value of an array... hash(c1.signature()) -> TypeError: unhashable type: 'list' Since signature() backs value-based equality and hashing (merge_signature, AtomicVariable.equals, FrozenApply interning), Constant.equals() on two typed list constants raised as well. signature() now delegates to the inner type's constant signatures and returns a tuple, mirroring how ScalarConstant/TensorConstant provide their own hashable signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypedListConstantinherited the baseConstant.signature(), which returns(self.type, self.data). For a typed list,datais a Python list of arrays, so the signature raised on both operations it exists to support:Since
signature()backs value-based equality and hashing (merge_signature,AtomicVariable.equals,FrozenApplyinterning),Constant.equals()on two typed list constants raised too. It now delegates to the inner type's constant signatures and returns a plain tuple, mirroringScalarConstant/TensorConstant.This addresses problem 2 of #2044; the other items there (bare
Constant()instantiations, constructor dispatch) are left alone.Related Issue
Checklist
Type of change