Add ML-DSA support to X.509 signing and verification#14889
Open
alex wants to merge 2 commits into
Open
Conversation
Allow ML-DSA-44/65/87 keys to sign and verify X.509 certificates, certificate signing requests, and certificate revocation lists, and to be used as certificate public keys. ML-DSA, like Ed25519/Ed448, is a hashless signature scheme, so signing requires algorithm=None. https://claude.ai/code/session_01ENDmAD4rsLTkCw1QG9txBL
The arm in compute_signature_algorithm that rejects a hash algorithm passed alongside an ML-DSA key was not exercised by any test, leaving sign.rs below 100% coverage. https://claude.ai/code/session_01ENDmAD4rsLTkCw1QG9txBL
dadrian
approved these changes
May 22, 2026
reaperhulk
reviewed
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for using ML-DSA (FIPS 204) keys with X.509:
MLDSA44/MLDSA65/MLDSA87private keys.Like Ed25519/Ed448, ML-DSA is a hashless scheme, so signing requires
algorithm=None. The signing/verification dispatch insrc/rust/src/x509/sign.rsnow recognizes the three ML-DSA key types, mapping them to the existingMlDsa44/65/87AlgorithmParameters(the OIDs and ASN.1 variants already existed). The public OID constants this builds on were added in #14884.This requires a backend with ML-DSA support (AWS-LC, BoringSSL, or OpenSSL 3.5+); on other backends the new tests skip.
Test plan
verify_directly_issued_by, bad-signature rejection)tests/x509/suite passes against AWS-LC with no regressionscargo fmt/clippy,ruff, andmypycleanhttps://claude.ai/code/session_01ENDmAD4rsLTkCw1QG9txBL
Generated by Claude Code